remove spaces to match new helper events in 2023.5 #546
Conversation
|
Hey @LordSushiPhoenix, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
|
I did this modification in ikea_e1743.yaml and it did NOT work. In ikea_e1743.yaml, these would be lines 280 and 281. I replaced the old lines with the new lines, restarted home assistant, but still no dice. |
|
@rubinho76 I also changed my e1744 yaml, but didnt succeeded. Can you share your changes? |
Right? Lol ... What magic trick did @rubinho76 use? I literally copied the entire new raw YAML from @LordSushiPhoenix overtop of the original YAML and still no dice... |
if you copied the entire ikea_e2001_e2002.yaml file into your ikea_e1744.yaml that is likely why it didn't work. The two files are different before modification, and replacing the e1744 yaml with the e2001_e2002 yaml replaces the logic with logic for a different controller. Even e1743 and e1744 are different. |
|
No, I copied your new e1743.yaml over my existing e1743.yaml and no dice.
…On Sun, May 7, 2023 at 12:43 PM LordSushiPhoenix ***@***.***> wrote:
@rubinho76 <https://github.com/rubinho76> I also changed my e1744 yaml,
but didnt succeeded. Can you share your changes? I changes this part: [image:
IMG_4320]
<https://user-images.githubusercontent.com/81048302/236690221-5c6fbd77-6207-4367-8c1b-623ce8aa1da7.png>
Right? Lol ... What magic trick did @rubinho76
<https://github.com/rubinho76> use? I literally copied the entire new raw
YAML from @LordSushiPhoenix <https://github.com/LordSushiPhoenix> overtop
of the original YAML and still no dice...
if you copied the entire ikea_e2001_e2002.yaml file into your
ikea_e1744.yaml that is likely why it didn't work. The two files are
different before modification, and replacing the e1744 yaml with the
e2001_e2002 yaml replaces the logic with logic for a different controller.
Even e1743 and e1744 are different.
—
Reply to this email directly, view it on GitHub
<#546 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOBYVLIDZYIWHHEML2BUX5DXE7GKNANCNFSM6AAAAAAXXSR7LU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I have only taken over the modifications, i.e. removed the spaces. Everything else is still original. |
|
If I may, I would suggest instead considering the spaces optional (followed by ? in the regex), to both keep compatibility with old style messages and make the check a little bit less fragile to possible future changes. That said, using regex to check a JSON format message is pretty fragile by nature. |
|
Thanks @LordSushiPhoenix ! It fixed my issues with |
Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.
Sections marked as * are required and need to be filled in.
Breaking change
If your PR contains a breaking change for existing users, it is important to describe what breaks, how to make it work again and why we did this. This section will be used to craft the changelog entry, after your PR gets approved and merged.
Note: Remove this section if this PR is NOT a breaking change.
May break compatibility with Home Assistant versions before 2023.5
Proposed change*
Describe the big picture of your changes here, and why your pull request should be accepted. If it fixes a bug or resolves a feature request, be sure to put
closes #XXXXin this section to auto-close relevant issues.Please note that for important and breaking changes it's always better to open an issue first for discussing the proposal.
Make sure to provide enough information so that your pull request can be reviewed.
The last controller event format has changed in 2023.5 and broken some controller automations. Removing spaces fixes it. Mentioned in #543, but I don't expect these changes to affect the SNZB-01.
#544 (comment)
#543 (comment)
Checklist*
npm run formatbefore submitting my Pull Request.